Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protobuf_deps to WORKSPACE #20256

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Add protobuf_deps to WORKSPACE #20256

merged 2 commits into from
Sep 19, 2019

Conversation

rafi-kamal
Copy link
Contributor

@rafi-kamal
Copy link
Contributor Author

@gnossen

@gnossen
Copy link
Contributor

gnossen commented Sep 13, 2019

As I said in my original comment, this change is going to have to be made by all of our downstreams as well, so you'll have to modify this Bazel test as well.

@gnossen gnossen self-assigned this Sep 13, 2019
@rafi-kamal
Copy link
Contributor Author

Thanks, added it.

@gnossen
Copy link
Contributor

gnossen commented Sep 13, 2019

Cross-reference: bazelbuild/bazel#1943

@rafi-kamal
Copy link
Contributor Author

Friendly ping :)

@jtattermusch
Copy link
Contributor

Known failures:
#20095
the PHP interop errors are due to a transient "https://packagist.org/p/provider-2019-04%246e9d3eb372b3e43a14ff5ba6e6cb037890da61f8f3288e468ac3a1a1bbbf27c1.json" file could not be downloaded (HTTP/1.1 404 Not Found) error.

@jtattermusch jtattermusch merged commit 538751e into grpc:master Sep 19, 2019
@rafi-kamal rafi-kamal mentioned this pull request Sep 20, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnossen gnossen gnossen approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@veblush veblush Awaiting requested review from veblush veblush is a code owner

Assignees

@gnossen gnossen

Labels
area/build infra/Bazel kind/bug lang/all wrapped languages release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafi-kamal @gnossen @jtattermusch @grpc-kokoro