[EventEngine] Windows endpoints keep their EventEngines alive #32560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Vignesh2208
approved these changes
Mar 8, 2023
copybara-service
bot
added
the
imported
drfloob
added a commit
that referenced
this pull request
Mar 14, 2023
…s WSARecv operations (#32563) Built on #32560 When calling EventEngine::Read, if a synchronous WSARecv call completes successfully and 1) the read buffer is not full, and 2) the stream remains open, then the endpoint will now chain execution of more synchronous WSARecvs. The chain is broken and the on_read callback is called when either there are errors, the next call would block, the buffer is full, or the stream is closed. Something like this is helpful to prevent excessive read callback execution under a flood of tiny payloads, presuming messages are not being combined as one would usually expect (see `//test/core/iomgr:endpoint_pair_test`, and Nagle's algorithm).
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…2560) Discovered via `bazel test --test_env=GRPC_EXPERIMENTS=event_engine_client //test/core/iomgr:endpoint_pair_test`. CI experiments can be enabled generally on Windows once a few fixes and improvements are completed.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…s WSARecv operations (grpc#32563) Built on grpc#32560 When calling EventEngine::Read, if a synchronous WSARecv call completes successfully and 1) the read buffer is not full, and 2) the stream remains open, then the endpoint will now chain execution of more synchronous WSARecvs. The chain is broken and the on_read callback is called when either there are errors, the next call would block, the buffer is full, or the stream is closed. Something like this is helpful to prevent excessive read callback execution under a flood of tiny payloads, presuming messages are not being combined as one would usually expect (see `//test/core/iomgr:endpoint_pair_test`, and Nagle's algorithm).
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Discovered via `bazel test --test_env=GRPC_EXPERIMENTS=event_engine_client //test/core/iomgr:endpoint_pair_test`. CI experiments can be enabled generally on Windows once a few fixes and improvements are completed.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…s WSARecv operations (#32563) Built on #32560 When calling EventEngine::Read, if a synchronous WSARecv call completes successfully and 1) the read buffer is not full, and 2) the stream remains open, then the endpoint will now chain execution of more synchronous WSARecvs. The chain is broken and the on_read callback is called when either there are errors, the next call would block, the buffer is full, or the stream is closed. Something like this is helpful to prevent excessive read callback execution under a flood of tiny payloads, presuming messages are not being combined as one would usually expect (see `//test/core/iomgr:endpoint_pair_test`, and Nagle's algorithm).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered via
bazel test --test_env=GRPC_EXPERIMENTS=event_engine_client //test/core/iomgr:endpoint_pair_test. CI experiments can be enabled generally on Windows once a few fixes and improvements are completed.