A86: xDS-Based HTTP CONNECT #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Sep 25, 2024
alyssawilk
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Oct 9, 2024
http_11_proxy: Make inner transport_socket config optional Given that the top-level [Cluster.transport_socket](https://github.com/envoyproxy/envoy/blob/1a153166a6d1e9336ee8982d1a00ba98655c9d39/api/envoy/config/cluster/v3/cluster.proto#L1099) field is optional and defaults to plaintext, this should also be optional. gRPC is adding support for this transport socket, but they do not have a `raw_buffer` to explicitly configure. See grpc/proposal#455 (comment) for additional context. Risk Level: Low. Testing: Existing tests. Docs Changes: n/a Release Notes: Done. --------- Signed-off-by: Tony Allen <[email protected]>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Oct 9, 2024
http_11_proxy: Make inner transport_socket config optional Given that the top-level [Cluster.transport_socket](https://github.com/envoyproxy/envoy/blob/1a153166a6d1e9336ee8982d1a00ba98655c9d39/api/envoy/config/cluster/v3/cluster.proto#L1099) field is optional and defaults to plaintext, this should also be optional. gRPC is adding support for this transport socket, but they do not have a `raw_buffer` to explicitly configure. See grpc/proposal#455 (comment) for additional context. Risk Level: Low. Testing: Existing tests. Docs Changes: n/a Release Notes: Done. --------- Signed-off-by: Tony Allen <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ c6761de5f33e97758471c6b973a57a5c2e5db925
Stevenjin8
pushed a commit
to Stevenjin8/envoy
that referenced
this pull request
Oct 10, 2024
…y#36414) http_11_proxy: Make inner transport_socket config optional Given that the top-level [Cluster.transport_socket](https://github.com/envoyproxy/envoy/blob/1a153166a6d1e9336ee8982d1a00ba98655c9d39/api/envoy/config/cluster/v3/cluster.proto#L1099) field is optional and defaults to plaintext, this should also be optional. gRPC is adding support for this transport socket, but they do not have a `raw_buffer` to explicitly configure. See grpc/proposal#455 (comment) for additional context. Risk Level: Low. Testing: Existing tests. Docs Changes: n/a Release Notes: Done. --------- Signed-off-by: Tony Allen <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Oct 11, 2024
Implements gRFC A86 (grpc/proposal#455). Closes #37800 PiperOrigin-RevId: 684963953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.