Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fallback] Initial version of the interop test. #100

Merged
merged 28 commits into from
Aug 7, 2024
Merged

[Fallback] Initial version of the interop test. #100

merged 28 commits into from
Aug 7, 2024

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jul 1, 2024

I suggest merging this as soon as possible and then make smaller pull requests to better integrate new test with the framework.

There will be another PR that adds Go control panel docker image.

@eugeneo
Initial version of the interop test.
7a8cced 
I suggest merging this as soon as possible and then make
smaller pull requests to better integrate new test with
the framework.

There will be another PR that adds Go control panel docker
image.
@eugeneo eugeneo requested a review from sergiitk July 1, 2024 23:46
sergiitk
sergiitk reviewed Jul 2, 2024
View reviewed changes
protos/grpc/testing/xdsconfig/control.proto Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
templates/bootstrap.mako Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Show resolved Hide resolved
@sergiitk sergiitk changed the title Initial version of the interop test. [Fallback] Initial version of the interop test. Jul 2, 2024
sergiitk
sergiitk reviewed Jul 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
eugeneo
eugeneo commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. PTAL.

protos/grpc/testing/xdsconfig/control.proto Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
templates/bootstrap.mako Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sergiitk
sergiitk previously requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More notes and suggestions how to pass the linter.

tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
eugeneo
eugeneo commented Jul 18, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I addressed the comments.

framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Show resolved Hide resolved
protos/grpc/testing/xdsconfig/control.proto Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
XuanWang-Amos
XuanWang-Amos reviewed Jul 24, 2024
View reviewed changes
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
eugeneo
eugeneo commented Jul 26, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews! I addressed the comments

framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
@sergiitk sergiitk requested a review from easwars July 26, 2024 19:11
@eugeneo eugeneo requested a review from a team as a code owner July 29, 2024 18:04
@eugeneo eugeneo requested a review from sergiitk July 29, 2024 18:04
@eugeneo eugeneo mentioned this pull request Jul 29, 2024
Merged
XuanWang-Amos
XuanWang-Amos reviewed Aug 5, 2024
View reviewed changes
tests/fallback_test.py Outdated Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
tests/fallback_test.py Show resolved Hide resolved
@sergiitk sergiitk self-requested a review August 6, 2024 18:14
@sergiitk
Copy link
Member

sergiitk commented Aug 6, 2024

@sergiitk sergiitk self-requested a review now
I think this dismissed my last review status.

@XuanWang-Amos - feel free to finish the review and approve when you think it's ready.

@sergiitk sergiitk dismissed their stale review August 6, 2024 18:18

Delegating to Xuan

XuanWang-Amos
XuanWang-Amos approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay!

@XuanWang-Amos XuanWang-Amos merged commit 53d1d8e into grpc:main Aug 7, 2024
7 checks passed
@eugeneo eugeneo deleted the fallback-test-initial branch August 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

@easwars easwars Awaiting requested review from easwars

@sergiitk sergiitk Awaiting requested review from sergiitk

Assignees

@sergiitk sergiitk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugeneo @sergiitk @XuanWang-Amos