Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move server runner's enable_dualstack to ServerDeploymentArgs #128

Merged
merged 1 commit into from
Sep 20, 2024
Merged

move server runner's enable_dualstack to ServerDeploymentArgs #128

merged 1 commit into from
Sep 20, 2024

Conversation

purnesh42H
Copy link
Contributor

No description provided.

@purnesh42H purnesh42H requested a review from a team as a code owner August 28, 2024 13:50
@purnesh42H purnesh42H force-pushed the enable-dualstack-flag-refactor branch 4 times, most recently from 2c940be to dd65a8b Compare August 28, 2024 14:36
@purnesh42H
Copy link
Contributor Author

@purnesh42H
Copy link
Contributor Author

purnesh42H commented Aug 28, 2024 •
edited
Loading

larry-safran
larry-safran approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@larry-safran larry-safran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the tests still work, it seems okay to me.

@purnesh42H
Copy link
Contributor Author

As long as the tests still work, it seems okay to me.

yeah i have put the test run above which succeeded

XuanWang-Amos
XuanWang-Amos approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purnesh42H
Copy link
Contributor Author

purnesh42H commented Sep 20, 2024 •
edited
Loading

@purnesh42H purnesh42H merged commit a752d2b into grpc:main Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

@larry-safran larry-safran larry-safran approved these changes

@sergiitk sergiitk Awaiting requested review from sergiitk sergiitk is a code owner automatically assigned from grpc/grpc-psm-interop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purnesh42H @XuanWang-Amos @larry-safran