Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8x faster copy #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

8x faster copy #306

wants to merge 1 commit into from

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Jun 4, 2020

@jsf-clabot
Copy link

jsf-clabot commented Jun 4, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@greggman greggman force-pushed the 8x-faster-copy branch 2 times, most recently from bff5924 to 5da37ca Compare June 4, 2020 18:53
@greggman
Copy link
Contributor Author

greggman commented Jun 4, 2020

The errors seem to be unrelated to my change. Instead mkdirp requires node 8 or greater as it's using destructuring syntax.

Base automatically changed from master to main March 22, 2021 15:10
@db2222
Copy link

db2222 commented Jul 16, 2023

@greggman This is such a significant improvement! It would be very nice if this got merged and a new version released. However, this project seems to be dead unfortunately. Are there therefore any reservations if I release a changed version to npmjs? It should be seemingly allowed as the project is marked with the MIT license.

db2222 added a commit to db2222/grunt-contrib-copy-faster that referenced this pull request Jul 16, 2023
@db2222
Improve copy times.
a0bf80f 
This is directly taken from gruntjs#306.
So @greggman deserves all the praise!
db2222 added a commit to db2222/grunt-contrib-copy-faster that referenced this pull request Jul 19, 2023
@db2222
Corrections/improvements in regards to fs.copyFileSync.
d143941 
- Strangely even though fs.copyFileSync was never used as gruntjs#306 checked it too strictly the copy times were faster. This made me initially falsely believe that it was active. Seemingly another commit must have had an improving effect compared to v1.0.0 (maybe b508a56?).
- Changed it so that fs.copyFileSync really now is always used if it's possible. With this the difference is like night & day!
- Furthermore fixed that missing sub-directories weren't created.
- Added an option to make it switchable. The default is true. Meaning the options encoding & process can't be used unless you explicitly deactivate useFsCopy.
- Also copyFileSync shouldn't skip the logic in regards to syncTimestamp and chmodSync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greggman @jsf-clabot @db2222