Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing TFLint section of README #109

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fixing TFLint section of README #109

merged 1 commit into from
Mar 21, 2024

Conversation

nilsonneto
Copy link
Contributor

@nilsonneto nilsonneto commented Nov 30, 2023 •
edited
Loading

Description

README made reference to the wrong default value of the root keyword.

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

@nilsonneto
Fixing TFLint section of README
b9a38d2 
README made reference to the wrong default value of the root keyword.
james03160927
james03160927 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcagle3 gcagle3 merged commit 630cb7c into gruntwork-io:master Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsonneto @james03160927 @gcagle3