Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate packer #57 #58

Merged
merged 1 commit into from
Sep 27, 2021
Merged

validate packer #57 #58

merged 1 commit into from
Sep 27, 2021

Conversation

queglay
Copy link
Contributor

@queglay queglay commented Sep 24, 2021

This test checks packer files for syntax errors.

@queglay queglay mentioned this pull request Sep 24, 2021
Closed
infraredgirl
infraredgirl approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@infraredgirl infraredgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@infraredgirl infraredgirl merged commit 2053191 into gruntwork-io:master Sep 27, 2021
@infraredgirl
Copy link
Contributor

https://github.com/gruntwork-io/pre-commit/releases/tag/v0.1.15

@tpdownes
Copy link
Contributor

tpdownes commented Oct 4, 2021 •
edited
Loading

This probably should not have been so wide in scope:

  files: \.pkr.*$

For example, it's somewhat accidentally hitting:

pkrvars.hcl

but it's also hitting files I use to template Packer files (e.g. pkr.hcl.tmpl) I'm going to submit a PR to lower its ambitions.

@tpdownes tpdownes mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infraredgirl infraredgirl infraredgirl approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queglay @infraredgirl @tpdownes