tflint has deprecated the 'tflint FILE/DIR' syntax #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolverineFan
requested review from
brikis98,
zackproser,
arsci,
pete0emerson,
ellisonc and
james03160927
as code owners
|
@WolverineFan could you rebase and pull in the recent changes from PR #92? We'd like to preserve the functionality from that PR to pass custom arguments, but would also like to implement your fix. Thanks in advance! |
|
Oh splendid! Let me run the tests real quick and then we can move this along. |
joelbcastillo
added a commit
to Hyperfine/pre-commit
that referenced
this pull request
Oct 25, 2023
* 'master' of ssh://github.com/gruntwork-io/pre-commit: [skip ci] Removing former Grunts (gruntwork-io#101) [skip ci] git-xargs programmatic commit (gruntwork-io#99) tflint has deprecated the 'tflint FILE/DIR' syntax (gruntwork-io#95) Add support to use args in tflint (gruntwork-io#92) Add a golangci-lint hook (gruntwork-io#93) Add sentinel fmt hook (gruntwork-io#89) Ignore hash links (gruntwork-io#86) Update CODEOWNERS (gruntwork-io#85) Update deprecated circleci images to latest (gruntwork-io#72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tflintversionv0.46.0deprecates support for thetflint FILE/DIRcommand-line syntax. It has been replaced withtflint --chdir DIR --filter FILE. See terraform-linters/tflint#1687 for more details.Documentation
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955orbug/missing-count-param-434.Related Issues
Fixes #94