Implement minimal debug feature #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
commented
Jul 24, 2020
brikis98
reviewed
Jul 24, 2020
| // account all the generated sources. | ||
| func terraformModuleVariables(terragruntOptions *options.TerragruntOptions) ([]string, error) { | ||
| modulePath := terragruntOptions.WorkingDir | ||
| module, diags := tfconfig.LoadModule(modulePath) |
There was a problem hiding this comment.
Oh, this library makes this super easy, nice!
|
Closing in favor of #1267 |
|
Reopened given #1267 (comment) |
|
@brikis98 any objections to merging this version of debug mode in? This is the original implementation, where it doesn't touch the main way terragrunt passes vars, and instead introduces debug mode as a way to emit the tfvars json file. |
|
Thanks for review! Merging and releasing now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #1137 and reduces the scope to just outputting a workable tfvars file. This should be the minimal increment for a usable debug command that should significantly improve status quo.