Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TERRAGRUNT_PROVIDER_CACHE_DISABLE_PARTIAL_LOCK_FILE reference #3206

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

maonat
Copy link
Contributor

@maonat maonat commented Jun 13, 2024

Description

  • Removed reference for TERRAGRUNT_PROVIDER_CACHE_DISABLE_PARTIAL_LOCK_FILE as it's been removed since v0.58.3 release of terragrunt

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

* Removed reference for TERRAGRUNT_PROVIDER_CACHE_DISABLE_PARTIAL_LOCK_FILE as it's been removed since v0.58.3
@maonat maonat requested a review from denis256 as a code owner June 13, 2024 11:15
@maonat
Copy link
Contributor Author

maonat commented Jun 13, 2024

@denis256 Because there is no documentation whatsoever on the new approach introduced in v0.58.3, is there anything to be done to have the same result in the newest versions? Or was this mistakenly removed from the application? I couldn't find any release notes about this change.

@yhakbar yhakbar requested a review from levkohimins June 13, 2024 12:30
@levkohimins
Copy link
Contributor

Hi @maonat, Thanks for your contribution!

Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maonat
Copy link
Contributor Author

maonat commented Jun 13, 2024

@levkohimins is there a chance to know if the change to remove this was planned and the functionality to use the cached providers works without this parameter also using parallelism?
The PR where this was implemented is #3001 and as stated above in my comment, I couldn't find any release note about it.

Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maonat,
Could you please remove other mentions of terragrunt-provider-cache-disable-partial-lock-file? :

docs/_docs/04_reference/cli-options.md:78:6:  - [terragrunt-provider-cache-disable-partial-lock-file](#terragrunt-provider-cache-disable-partial-lock-file)
docs/_docs/04_reference/cli-options.md:78:60:  - [terragrunt-provider-cache-disable-partial-lock-file](#terragrunt-provider-cache-disable-partial-lock-file)
docs/_docs/04_reference/cli-options.md:746:6:  - [terragrunt-provider-cache-disable-partial-lock-file](#terragrunt-provider-cache-disable-partial-lock-file)
docs/_docs/04_reference/cli-options.md:746:60:  - [terragrunt-provider-cache-disable-partial-lock-file](#terragrunt-provider-cache-disable-partial-lock-file)

If I do this, I won't be able to approve this pull request.

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@maonat maonat requested a review from levkohimins June 13, 2024 13:03
@levkohimins
Copy link
Contributor

@levkohimins is there a chance to know if the change to remove this was planned and the functionality to use the cached providers works without this parameter also using parallelism? The PR where this was implemented is #3001 and as stated above in my comment, I couldn't find any release note about it.

We have removed TERRAGRUNT_PROVIDER_CACHE_DISABLE_PARTIAL_LOCK_FILE from the code as it became unnecessary after adding lock file generation #3089. Nothing else has changed, so using parallelism is still safe with cached providers.

@maonat
Copy link
Contributor Author

maonat commented Jun 13, 2024

@levkohimins is there a chance to know if the change to remove this was planned and the functionality to use the cached providers works without this parameter also using parallelism? The PR where this was implemented is #3001 and as stated above in my comment, I couldn't find any release note about it.

We have removed TERRAGRUNT_PROVIDER_CACHE_DISABLE_PARTIAL_LOCK_FILE from the code as it became unnecessary after adding lock file generation #3089. Nothing else has changed, so using parallelism is still safe with cached providers.

Okay found also the merge #3055
Thanks!

PS: Is there a way to get in contact with you directly on a slack? I saw that you have a slack for the community but allows only emails with gruntwork.io and empatica.com domain.
Thanks

@levkohimins
Copy link
Contributor

levkohimins commented Jun 13, 2024

PS: Is there a way to get in contact with you directly on a slack? I saw that you have a slack for the community but allows only emails with gruntwork.io and empatica.com domain. Thanks

You can contact me using @Levko/Gruntwork in Slack.

Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@levkohimins levkohimins merged commit b47f74c into gruntwork-io:master Jun 13, 2024
4 checks passed
@maonat maonat deleted the patch-1 branch June 13, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants