Skip to content

Commit

Permalink
Rename markor baseactivity and use everywhere, move OpenEditor activi…
Browse files Browse the repository at this point in the history
…ty to subdir, by @gsantner
  • Loading branch information
gsantner committed Dec 1, 2021
1 parent 5d1ce8a commit 9a8673a
Show file tree
Hide file tree
Showing 12 changed files with 25 additions and 25 deletions.
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
</intent-filter>
</activity>
<activity
android:name=".activity.DocumentRelayActivity"
android:name=".activity.openeditor.OpenEditorFromShortcutOrWidgetActivity"
android:launchMode="singleTop"
android:theme="@android:style/Theme.NoDisplay" />
<activity
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import android.os.Build;
import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.widget.DividerItemDecoration;
import android.support.v7.widget.LinearLayoutManager;
import android.support.v7.widget.RecyclerView;
Expand Down Expand Up @@ -47,7 +46,7 @@
import java.util.Map;
import java.util.Set;

public class ActionOrderActivity extends AppCompatActivity {
public class ActionOrderActivity extends MarkorBaseActivity {

public static final String EXTRA_FORMAT_KEY = "FORMAT_KEY";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
import butterknife.ButterKnife;
import other.so.AndroidBug5497Workaround;

public class DocumentActivity extends AppActivityBase {
public class DocumentActivity extends MarkorBaseActivity {
public static final String EXTRA_DO_PREVIEW = "EXTRA_DO_PREVIEW";

@BindView(R.id.document__placeholder_fragment)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
import butterknife.OnLongClick;
import butterknife.OnPageChange;

public class MainActivity extends AppActivityBase implements FilesystemViewerFragment.FilesystemFragmentOptionsListener, BottomNavigationView.OnNavigationItemSelectedListener {
public class MainActivity extends MarkorBaseActivity implements FilesystemViewerFragment.FilesystemFragmentOptionsListener, BottomNavigationView.OnNavigationItemSelectedListener {

public static boolean IS_DEBUG_ENABLED = false;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import net.gsantner.markor.util.AppSettings;
import net.gsantner.opoc.activity.GsActivityBase;

public abstract class AppActivityBase extends GsActivityBase<AppSettings> {
public abstract class MarkorBaseActivity extends GsActivityBase<AppSettings> {

@Override
public Integer getNewNavigationBarColor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
import butterknife.ButterKnife;
import other.writeily.widget.WrMarkorWidgetProvider;

public class SettingsActivity extends AppActivityBase {
public class SettingsActivity extends MarkorBaseActivity {

@SuppressWarnings("WeakerAccess")
public static class RESULT {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
package net.gsantner.markor.activity.openeditor;

import android.content.Intent;
import android.support.v7.app.AppCompatActivity;

import net.gsantner.markor.R;
import net.gsantner.markor.activity.DocumentActivity;
import net.gsantner.markor.activity.MarkorBaseActivity;
import net.gsantner.markor.model.Document;
import net.gsantner.markor.util.AppSettings;
import net.gsantner.opoc.util.ActivityUtils;
Expand All @@ -22,7 +22,7 @@

import java.io.File;

public class OpenEditorActivity extends AppCompatActivity {
public class OpenEditorActivity extends MarkorBaseActivity {
protected void openEditorForFile(File file) {
Intent openIntent = new Intent(getApplicationContext(), DocumentActivity.class)
.setAction(Intent.ACTION_CALL_BUTTON)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
package net.gsantner.markor.activity;
package net.gsantner.markor.activity.openeditor;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;

import net.gsantner.markor.activity.DocumentActivity;
import net.gsantner.markor.activity.MarkorBaseActivity;

/**
* This Activity exists solely to launch DocumentActivity with the correct intent
* it is necessary as widget and shortcut intents do not respect MultipleTask etc
*/
public class DocumentRelayActivity extends Activity {
public class OpenEditorFromShortcutOrWidgetActivity extends MarkorBaseActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import android.os.Bundle;
import android.support.annotation.Nullable;

import net.gsantner.markor.activity.DocumentRelayActivity;
import net.gsantner.markor.model.Document;

public class OpenShareIntoActivity extends OpenEditorActivity {
Expand All @@ -22,7 +21,7 @@ public class OpenShareIntoActivity extends OpenEditorActivity {
protected void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

Intent openShare = new Intent(this, DocumentRelayActivity.class)
Intent openShare = new Intent(this, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_SEND)
.putExtra(Document.EXTRA_PATH_IS_FOLDER, true)
.putExtra(Intent.EXTRA_TEXT, "");
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/net/gsantner/markor/util/ShareUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import android.widget.Toast;

import net.gsantner.markor.R;
import net.gsantner.markor.activity.DocumentRelayActivity;
import net.gsantner.markor.activity.openeditor.OpenEditorFromShortcutOrWidgetActivity;
import net.gsantner.markor.model.Document;

public class ShareUtil extends net.gsantner.opoc.util.ShareUtil {
Expand All @@ -35,7 +35,7 @@ public void createLauncherDesktopShortcut(Document document) {
// So basically only for java.io.File Objects. Virtual files, or content://
// in private/restricted space won't work - because of missing permission grant when re-launching
if (document != null && document.getFile() != null && !TextUtils.isEmpty(document.getTitle())) {
Intent shortcutIntent = new Intent(_context, DocumentRelayActivity.class)
Intent shortcutIntent = new Intent(_context, OpenEditorFromShortcutOrWidgetActivity.class)
.setData(Uri.fromFile(document.getFile()));
super.createLauncherDesktopShortcut(shortcutIntent, R.drawable.ic_launcher, document.getTitle());
Toast.makeText(_context, R.string.tried_to_create_shortcut_for_this_notice, Toast.LENGTH_LONG).show();
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/java/net/gsantner/markor/util/ShortcutUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import android.support.annotation.NonNull;

import net.gsantner.markor.R;
import net.gsantner.markor.activity.DocumentRelayActivity;
import net.gsantner.markor.activity.openeditor.OpenEditorFromShortcutOrWidgetActivity;

import java.io.File;
import java.util.ArrayList;
Expand Down Expand Up @@ -61,7 +61,7 @@ public static void setShortcuts(@NonNull Context context) {
final AppSettings appSettings = new AppSettings(context);

// Create the to-do shortcut
Intent openTodo = new Intent(context, DocumentRelayActivity.class)
Intent openTodo = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_EDIT)
.setData(Uri.fromFile(appSettings.getTodoFile()));

Expand All @@ -74,7 +74,7 @@ public static void setShortcuts(@NonNull Context context) {
newShortcuts.add(shortcutToDo);

// Create the QuickNote shortcut
Intent openQuickNote = new Intent(context, DocumentRelayActivity.class)
Intent openQuickNote = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_EDIT)
.setData(Uri.fromFile(appSettings.getQuickNoteFile()));

Expand All @@ -97,7 +97,7 @@ public static void setShortcuts(@NonNull Context context) {

File file = new File(filePath);

Intent openFile = new Intent(context, DocumentRelayActivity.class)
Intent openFile = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_EDIT)
.setData(Uri.fromFile(file));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import android.widget.RemoteViews;

import net.gsantner.markor.R;
import net.gsantner.markor.activity.DocumentRelayActivity;
import net.gsantner.markor.activity.openeditor.OpenEditorFromShortcutOrWidgetActivity;
import net.gsantner.markor.activity.MainActivity;
import net.gsantner.markor.model.Document;
import net.gsantner.markor.util.AppSettings;
Expand Down Expand Up @@ -72,7 +72,7 @@ public void onUpdate(Context context, AppWidgetManager appWidgetManager, int[] a
AppSettings appSettings = new AppSettings(context);

// ~~~Create new File~~~ Share empty text into markor, easier to access from widget than new file dialog
Intent openShare = new Intent(context, DocumentRelayActivity.class)
Intent openShare = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_SEND)
.putExtra(Document.EXTRA_PATH, directoryF)
.putExtra(Document.EXTRA_PATH_IS_FOLDER, true)
Expand All @@ -84,14 +84,14 @@ public void onUpdate(Context context, AppWidgetManager appWidgetManager, int[] a
views.setOnClickPendingIntent(R.id.widget_header, PendingIntent.getActivity(context, requestCode++, goToMain, 0));

// Open To-do
Intent openTodo = new Intent(context, DocumentRelayActivity.class)
Intent openTodo = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_EDIT)
.putExtra(Document.EXTRA_PATH, appSettings.getTodoFile())
.putExtra(Document.EXTRA_PATH_IS_FOLDER, false);
views.setOnClickPendingIntent(R.id.widget_todo, PendingIntent.getActivity(context, requestCode++, openTodo, 0));

// Open QuickNote
Intent openQuickNote = new Intent(context, DocumentRelayActivity.class)
Intent openQuickNote = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class)
.setAction(Intent.ACTION_EDIT)
.putExtra(Document.EXTRA_PATH, appSettings.getQuickNoteFile())
.putExtra(Document.EXTRA_PATH_IS_FOLDER, false);
Expand All @@ -111,7 +111,7 @@ public void onUpdate(Context context, AppWidgetManager appWidgetManager, int[] a
views.setEmptyView(R.id.widget_list_container, R.id.widget_empty_hint);
views.setRemoteAdapter(R.id.widget_notes_list, notesListIntent);

Intent openNoteIntent = new Intent(context, DocumentRelayActivity.class);
Intent openNoteIntent = new Intent(context, OpenEditorFromShortcutOrWidgetActivity.class);
PendingIntent openNotePendingIntent = PendingIntent.getActivity(context, requestCode++,
openNoteIntent, PendingIntent.FLAG_UPDATE_CURRENT);
views.setPendingIntentTemplate(R.id.widget_notes_list, openNotePendingIntent);
Expand Down

0 comments on commit 9a8673a

Please sign in to comment.