Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to androidx & newer Android architecture #1359

Closed
gsantner opened this issue Jun 2, 2021 · 7 comments · Fixed by #1521
Closed

Migrate to androidx & newer Android architecture #1359

gsantner opened this issue Jun 2, 2021 · 7 comments · Fixed by #1521
Assignees

Comments

@gsantner
Copy link
Owner

gsantner commented Jun 2, 2021

General information

  • App version: 2.x
  • System: Android 11

Description

Remove appcompat from markor and opoc, upgrade to AndroidX. Don't use transformation magic, make adjustments at code & androidx imports.

@harshad1
Copy link
Collaborator

harshad1 commented Jun 2, 2021

Why not use the auto migration? Seems to be the recommended route: https://developer.android.com/jetpack/androidx/migrate

@gsantner
Copy link
Owner Author

gsantner commented Jun 2, 2021

I know this one exists, but I prefer to stay away from it (thats why I've mentioned transformation magic).

grafik

As of applying changes/fixes by android tooling & IDE - yes. But a lot of special/greylist code is also used, which will need special attention - like coloring and showing menu icons.
Also the current solution for Settings/Preferences will need a bigger rewrite - probably one of the bigger points.

@harshad1
Copy link
Collaborator

harshad1 commented Jun 2, 2021

👍

@gsantner
Copy link
Owner Author

gsantner commented Aug 21, 2021

one of my todo.txt shower thoughts says along markor file write proxy to /data/ app-temp-dir, read file from intent, write back on close, use tmp file for java.io.File. Thats the rough plan I have in mind for coping with newer restrictions. Let aside file browser.

@harshad1
Copy link
Collaborator

There seems to be some sort of proposed mechanism for requesting all file access for file managers. We can try that first.

Needless to say, this will not affect F-Droid

@gsantner
Copy link
Owner Author

gsantner commented Aug 21, 2021

probably default/gplayFlavor also comes into play for it (from gradle)

There seems to be some sort of proposed mechanism for requesting all file access for file managers

Yeah but its hard to get. To what I see big companies get it more easy, but probably not seo esy for smaller projects like this

@gsantner gsantner changed the title Migrate everything from appcompat to androidx Migrate to androidx & newer Android architecture Sep 8, 2021
gsantner added a commit that referenced this issue Dec 4, 2021
@gsantner gsantner self-assigned this Jan 22, 2022
@gsantner gsantner removed the feature label Jan 22, 2022
gsantner added a commit that referenced this issue Feb 10, 2022
CI/CD github update java version to 11
@harshad1
Copy link
Collaborator

harshad1 commented Apr 9, 2022

Do we want to immitate how syncthing accesses files? I.e. use SAF and ACTION_OPEN_DOCUMENT_TREE to gain access to a subtree. We will have to ask the user to pick the notebook directory this way. Obviously, we will then not be able to navigate up out of the notebook. But this should meet 90% of a user's needs while meeting android 12's limitations.

As far as I can tell, we can just use regular File access within the notebook directory once permissions are granted.

Do we want to go down this path? It adds a limitation, but makes Markor somewhat more future-proof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants