Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Show Line Numbers? #2057

Closed
3 of 4 tasks
guanglinn opened this issue Jun 2, 2023 · 4 comments · Fixed by #2062
Closed
3 of 4 tasks

How to Show Line Numbers? #2057

guanglinn opened this issue Jun 2, 2023 · 4 comments · Fixed by #2062

Comments

@guanglinn
Copy link
Contributor

guanglinn commented Jun 2, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

How to show line numbers in Markor?
This involves source code in edit mode and markdown code blocks in view mode.

Information

App Version: v2.10.9 (146)

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@gsantner
Copy link
Owner

gsantner commented Jun 2, 2023

By programming it and creating a merge request :-).

This has been asked a few times already, please search issues.

@gsantner gsantner closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
@guanglinn
Copy link
Contributor Author

guanglinn commented Jun 2, 2023 via email

@gsantner
Copy link
Owner

gsantner commented Jun 2, 2023

Great to hear that would be awesome. There are not too much people contributing : -D.

@guanglinn
Copy link
Contributor Author

guanglinn commented Jun 4, 2023

Great to hear that would be awesome. There are not too much people contributing : -D.

Hi, this feature of line numbers support has been implemented, and I will make a pull request as soon as possible. 😁

Screenshot_20230605_071848_net.gsantner.markor_test.jpg

Screenshot_20230605_071852_net.gsantner.markor_test.jpg

@gsantner gsantner reopened this Jun 5, 2023
@gsantner gsantner linked a pull request Jun 5, 2023 that will close this issue
gsantner added a commit that referenced this issue Aug 14, 2023
@gsantner gsantner added this to the Markor v2.11 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants