ZimWiki: Syntax highlighting for code, global setting #1434
Conversation
…ighting optional (like in markdown)
|
Can you please move the setting to editmode -> syntay hl? So one setting that is applied to all formats. Intlstead of introducing duplicate for zim. |
|
Yes, I will change this. 👍 By the way, how about also moving the markdown table of contents setting to the general view mode settings? As zim view mode makes use of the MarkdownTextConverter, the setting affects both markdown and zim table of contents. (I can create a separate PR for this if you like) |
|
toc is under rework, dont touch now |
…he general editor settings (use common settings for both markdown and zim wiki now)
|
Et voilà, I moved both settings to the general "Editor > Syntax Highlighting" section, they are now commonly used by markdown and zim wiki.
Ah okay, didn't know that the table of contents is worked on at the moment, is there some PR or are you just doing some changes? Then it could make sense to just keep the inconsistent TOC setting location in mind and consider moving it in the future (to make more clear that it's used by markdown and zim) |
gsantner
changed the title
This PR adds the same functionality for ZimWiki for highlighting/formatting code which is already present for Markdown.
Before, code (inline and blocks) was always formatted as monospace, which led to severe performance problems in larger files with a lot of code samples.
Now, formatting code as monospace is optional (and turned off by default), but code is highlighted with gray background color (like for markdown). There's also the option to disable highlighting.