File change state indication & general improvements

[harshad1]

This PR addresses #1311

* is added to the end of the filename if the file is currently dirty Save icon is used to indicate if the file has changed

TODO:

• Add * in MainActivity
• Fix title alignment

[gsantner]

did you notice any craah/issue on the latest update?

[harshad1]

did you notice any craah/issue on the latest update?

No, but I am using this branch, not 2.8.4

[gsantner]

I've observed that at first app start, after granting the storage/file permission, the todo & quicknote tabs stay empty. restarting the app loads them properly.

also when removing permission via system settings, swiping to quicknote, new permission dialog, accept, and file stays empty.

---

nevermind the todo/quicknote tab permission comment. Fixed it on master, and it works for both current SDK29 and the upcoming SDK31 (MANAGE_EXTERNAL_STORAGE) usage #1521

[harshad1]

Issues remaining are

1. Left align the title (there is a lot of space between the back arrow and the title)
2. Reduce the spacing between the icons.

[gsantner]

I thought about removing the title generally, or generally making changes to the toolbar / new layout.
it should be OK / you don't need to waste time on it now

[harshad1]

I thought about removing the title generally

I don't think this would be a good idea. Besides, we use the title as another button for heading search / todo filter so it is not wasted space

it should be OK / you don't need to waste time on it now

I am still testing. Will see if I can get it done in a day or so. If I can't we can leave it as is

[gsantner]

do you think about more, or should I merge it now?

[harshad1]

@gsantner I am still testing + updating workflows without the back button and other edge cases. Lets wait a few days before merging,

[gsantner]

OK ready, or should I wait with testing?

[harshad1]

Ready imo. I have been using this without issues for the last couple days. Dec. 18, 2021 11:48:18 Gregor Santner ***@***.***>:

…

OK ready, or should I wait with testing? — Reply to this email directly, view it on GitHub[#1516 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAOZ3TEJO2PRQ6KCKCL7VP3URTQQBANCNFSM5JGKUADQ]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were assigned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAySURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeDVulAABbzDScQAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAOZ3TG4EKH42RFWISNYZ2TURTQQBA5CNFSM5JGKUAD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHNYTTVY.gif]

[gsantner]

OK then I think about merging and releasing an update somewhen in holidays

[harshad1]

May be better to merge soon to give it a gap between the merge and the release. That will give us a few more days to test... My concern is that some parts may not have been tested fully as my normal workflow does not use them. Dec. 20, 2021 14:28:50 Gregor Santner ***@***.***>:

…

OK then I think about merging and releasing an update somewhen in holidays — Reply to this email directly, view it on GitHub[#1516 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAOZ3TCCTN4GR2MXUR67433UR6U2DANCNFSM5JGKUADQ]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were assigned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAySURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeDVulAABbzDScQAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAOZ3THFD6I5L2JBCORTS53UR6U2DA5CNFSM5JGKUAD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHOASBYA.gif]

[gsantner]

Happy holidays & christmas