Increase performance on editables, more chunked operations, by @harshad1 #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshad1
changed the title
gsantner
force-pushed
the
master
branch
4 times, most recently
from
8bbdc13
to
b9c45c3
Compare
gsantner
approved these changes
May 21, 2022
gsantner
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the chunked operation via copy has been made more generic. It has also been applied to the regexReplaceAction (which is used for a lot of things). Should improve apparent performance and undo behavior.
TODO:
Apply to other common update functionsApply to groups of calls (i.e. indent + renumber)