-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked attachments #2106
Reworked attachments #2106
Conversation
app/src/main/java/net/gsantner/markor/format/asciidoc/AsciidocActionButtons.java
Show resolved
Hide resolved
// Create an image file name | ||
if (target != null && !target.isDirectory()) { | ||
photoFile = target; | ||
public void requestCameraPicture(final Activity activity, final File targetDir) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified code
|
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Show resolved
Hide resolved
@gsantner Images no longer render in view mode with the latest master. Do we know what might have broken? |
@gsantner @guanglinn I have addressed the image issue in the latest commit |
Great, didn't even notice regarding images ... as I use the release version mainly 😄 |
Yeah, I like using a branch with all my current PRs. It's the best way to find bugs. This branch is ready to review + merge imo. |
Thank you for all the changes & improvements, @harshad1 . I installed it on device and at didn't notice something off. I merge it now. Improvements are still welcome any time, and if it breaks something lets fix it. |
In this PR I have reworked the attachments system to fix bugs and reduce clicks.