Editor/viewer: Side margin improvements, closes #2111 #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The display area is expanded now. View modeBefore
After
Edit modeBefore
After
|
|
Does this interfere with grabbing the scrollbar for drag scroll on the right side? Otherwise I like this change. |
|
The scrollbar is not interfered. |
gsantner
changed the title
gsantner
reviewed
Oct 7, 2023
| <dimen name="activity_horizontal_margin">16dp</dimen> | ||
| <dimen name="activity_vertical_margin">16dp</dimen> | ||
| <dimen name="activity_horizontal_margin">12dp</dimen> | ||
| <dimen name="activity_vertical_margin">12dp</dimen> |
There was a problem hiding this comment.
This affects everything. All activities. Not just editor/viewer.
But let's try. It can be reverted if it is bad.
There was a problem hiding this comment.
I may have set the margins too small. 😬
|
Oh, Yes. We could take a look at the experience feedback. @gsantner |
|
Jup! Thank you very much for your time, it is merged now! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust margin or padding for editor and viewer.