Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Orgmode Preiview Support #2128

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Add Orgmode Preiview Support #2128

merged 6 commits into from
Dec 27, 2023

Conversation

bigger124
Copy link
Contributor

@bigger124 bigger124 commented Oct 13, 2023

Hello, I have added the orgmode preivew support, Please merge it.

ac159f207cbc43e31fc714a7689562d

4cd3cfcb60085851085e110d17ecb85

@gsantner
Copy link
Owner

@bigger124
there is no example showcase document like for all other formats.

Would you mind to add the one you show in screenshot?
This is especially there so users can see what the format supports, what they can do with it and how they do it.

Left side, no orgmode example, right side is the markdown example I created

a-append

Note: I don't use orgmode, and don't know all it's features and how it's written.

@bigger124
Copy link
Contributor Author

@bigger124 there is no example showcase document like for all other formats.

Would you mind to add the one you show in screenshot? This is especially there so users can see what the format supports, what they can do with it and how they do it.

Left side, no orgmode example, right side is the markdown example I created

a-append

Note: I don't use orgmode, and don't know all it's features and how it's written.

@gsantner I have added the orgmode showcase file.

@gsantner
Copy link
Owner

gsantner commented Oct 24, 2023

@bigger124
Thank you for adding the sample document, thats surely helpful! 😄

Question where did you get the org-bundle.js and the css file from? I see that you linked the org-js repository. But I can't find any bundle+css build like is commited here. I just want to make sure in the future that it can be updated (/how it should be updated), and that the hash matches between the project release and what we have here. This one org.js at least seems to be different then ours.

@bigger124
Copy link
Contributor Author

bigger124 commented Oct 25, 2023

@gsantner
Because org.js is a npm module, It can not be used directly in the html file, So I use browserify to export the org-bundle.js.

For example, browserify org.js > org-bundle.js.

I added this CSS file myself to address the issue of the serial number and title being too close together

@gsantner
Copy link
Owner

@bigger124 Thank you for the hint.

But when I do that browserify-ication I get different results. browserify-bundle-org.js.txt

Where did you download the source js file from and how did you use browserify on it? At the end I or anybody else need to follow the same steps to make sure we can update this later on when it's updateable.

@bigger124
Copy link
Contributor Author

bigger124 commented Nov 15, 2023

@gsantner Okay, I will provide a detailed description of the packaging process

  1. Install browserify
    npm install -g browserify
  2. Create a folder called org-compile
  3. Create new file called test.js in org-compile, and put following content in to the file
    let org = require('org'); window.org = org;
  4. Install org, run command in org-compile, note the org-js version in npm is 0.2.0
    npm install org
  5. Build, run command in org-compile
    browserify test.js > org-bundle.js

Then org-bundle.js will be created

@gsantner
Copy link
Owner

gsantner commented Dec 3, 2023

@bigger124 Due other PR's edited the same files/things, there are merge conflicts now.

Can you please fix it?

Let's merge it then.

@bigger124
Copy link
Contributor Author

@gsantner I've resolved the conflict。

@gsantner gsantner merged commit 3e9cdc0 into gsantner:master Dec 27, 2023
1 check passed
@gsantner
Copy link
Owner

Thank you, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants