Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment improvements / bugfix v4 #2148

Merged
merged 7 commits into from
Dec 3, 2023
Merged

Attachment improvements / bugfix v4 #2148

merged 7 commits into from
Dec 3, 2023

Conversation

harshad1
Copy link
Collaborator

Another set of improvements to attachments:

  1. Fixed how we set titles for attachments, preventing user-entered names from being overwritten
  2. Replaced broadcast with callback - makes it much easier to eliminate double inserts etc.

@harshad1 harshad1 changed the title Attachment improvements / bugfix v3 WIP: Attachment improvements / bugfix v3 Nov 12, 2023
@gsantner gsantner changed the title WIP: Attachment improvements / bugfix v3 WIP: Attachment improvements / bugfix v4 Nov 14, 2023
@gsantner gsantner marked this pull request as draft November 14, 2023 16:19
@harshad1 harshad1 mentioned this pull request Nov 18, 2023
Closed
@harshad1 harshad1 mentioned this pull request Nov 22, 2023
Closed
4 tasks
@harshad1 harshad1 changed the title WIP: Attachment improvements / bugfix v4 Attachment improvements / bugfix v4 Nov 25, 2023
@harshad1 harshad1 marked this pull request as ready for review November 25, 2023 01:12
@gsantner gsantner linked an issue Dec 3, 2023 that may be closed by this pull request
Crash on rotation when date selection dialog is open #2152
Closed
4 tasks
@gsantner gsantner added this to the Markor v2.12 milestone Dec 3, 2023
@gsantner gsantner merged commit c41e4d0 into gsantner:master Dec 3, 2023
1 check passed
@harshad1 harshad1 mentioned this pull request Dec 4, 2023
Closed
@harshad1 harshad1 deleted the attachment_improvements_v3 branch August 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsantner gsantner gsantner approved these changes

Assignees

@harshad1 harshad1

Labels
enhancement
Projects
None yet
Milestone
Markor v2.12
Development

Successfully merging this pull request may close these issues.

Crash on rotation when date selection dialog is open
2 participants
@harshad1 @gsantner