Create launcher widget for todo, closes #1997

[wshoy]

Introduces a Todo widget.

Todo:

• widget color scheme
• place cursor on the clicked line
• add widget preview image
• highlighting

[gsantner]

Thanks, let me know when you want a check

as you mentioned "widget color scheme settings": please don't make separate colors for that. You can use the same foreground (text) and background color like at the normal editor ("" basic color scheme""). There are getters for that in AppSettings.java

[harshad1]

Suggestion: reuse our existing widget but replace the provider with one which supplies lines from a todo.txt file.

You'll get 70% of the widget for free with good code reuse.

[wshoy]

In these commits:

• used the editor color scheme
• used Document and TodoTxtTask classes
• parse the task text (removed patterns such as creation dates (allows the widgets to be smaller))
• made a temporary workaround for placing the cursor on the clicked line

Suggestion: reuse our existing widget but replace the provider with one which supplies lines from a todo.txt file.

Which parts can be reused?

[harshad1]

Which parts can be reused?

Our current widget displays a list of files. Clicking on a file opens it.

What you want is a list of todo text lines where clicking on a line opens the todo file at the appropriate line.

We can achieve this by:

1. Changing the provider to provide lines
2. Changing the intent to open the file at the correct line

For 2 we just need to add an EXTRA_FILE with the file and EXTRA_FILE_LINE_NUMBER with the correct line number to each intent.

Both can be done by creating a new factory and reusing the rest of the widget. You will need to modify the other parts of the widget to use the correct factory though.

I may be missing something here, but I don't think so

[harshad1]

I would make an appSettings function called isTodoFile or something

I would also make sure this does not slow down opening / closing the todo file

[gsantner]

I didn't find any other usage like this (""istodo file check"), so suggest to keep it like that. Just bloats a new method with 1 usage then.

Opening we should be fine by usual file changed detection rules, as long widget writes immedeatly when not editing anymore.

Closing not sure maybe the call can be called in a new started thread

[harshad1]

Ok. Fair.

Either way one should absolute paths

[gsantner]

Roughly right or do you have something in mind which needs special attention?

guess the most important part is that the widget actually writes & reads filesystem at the right times and not resets it to older state the widget loaded in the past

[gsantner]

@wshoy
What do you think about that, possibly also in a later PR?:
To show a file selection dialog when making the widget, to select the file to create the widget for.
In AppSettings we can store what files are currently widget-used (to trigger the widget update)

At the end the most important part is that users don't lose data..so the file management part. Years of changes of Markor told..it's very difficult to get that somewhat 99% reliable working for most users.

I fear that another compound of the big calculations is then widgets and their currently loaded content. Hope it not makes too much issues.

[wshoy]

To show a file selection dialog when making the widget

It is a good idea. If that happens, I think, that the ToDo functionality should be prioritized in some way (maybe making it the default file or making a separate ToDo widget).
I assume, that the widget would be mostly used for the ToDo file, so it should be made easy for the user to do that.

[gsantner]

I assume that there is a split interest of todo vs notes/normal text editing. (so basically resembling why ToDo + QuickNote have their prominent separated existance)

Just to note again - feel free to make in the PR what you have time and interest on. I can only tell what I personally think is a good way. At the end most important need is that the file handling does not spread havoc and users lose recent modifications 😄

[gsantner]

Is the WIP marking still the case?

[harshad1]

I want to track down the issues you mentioned about virtual folders not being updated and see if there are any related issues with this approach.

[harshad1]

Aside from that this is done

[wshoy]

Is the WIP marking still the case?

It's finished.

[harshad1]

It would be really good to also highlight this.

Can do this pretty easily. See getSttHighlighter in MarkorDialogFactory.

[wshoy]

Yes, it needs highlighting.

String text = _tasks.get(position).getLine().replaceFirst(TodoTxtTask.PT_DATE + " ", "");
Spannable s = new SpannableString(text);
GsCallback.a1<Spannable> highlight = getSttHighlighter();
highlight.callback(s);
views.setTextViewText(R.id.todo_widget_item_text, s);

I have tried, but could not get it to work.
Using getSttHighlighter is seems to be limited to just highlighting patterns, which is good for editable text. I might be wrong.
A SpannableStringBuilder with TodoTxtTask would allow for parsing, choosing or changing elements shown.

[gsantner]

Plaintext/no highlight would be enough for the first version. Especially if you anyway think about further changes

The widget is not meant to replicate whole-Markor-editor-in-a-widget.

[wshoy]

Plaintext/no highlight would be enough for the first version.
Especially if you anyway think about further changes

Do you mean, that I should merge this PR and make further changes in another?
I also plan on making another widget for regular notes which would take some time.

[gsantner]

My plan would be to get a initial version that works well enough / not makes crashes. Preferred over full featured and half stuff bare works 😄

[wshoy]

Well... It works well on my machine 😅
I cannot find other ways to improve it beyond what I mentioned. Maybe you might find something?

[gsantner]

has conflicts now unfortunatley

[gsantner]

Thanks you, I merged the widget! 😄

Also tried it: Seems currently limited to just displaying ToDo, and that readonly.

I think editing is not a all too good idea, but selecting the file for each widget would make sense.

[ssebs]

Awesome to see this merged! Just curious, when will this be added to a release?

[gsantner]

Whenever the next release will be.

[enterprisey]

If I may be permitted an off-topic message, thank you so much for working on this feature! It'll be really helpful. I really appreciate the work everyone does!