Skip to content

Commit

Permalink
Include updated locations for dart third_party components into licens…
Browse files Browse the repository at this point in the history
…e ignore-list. (flutter#47770)

Incoming dart roll with
https://dart.googlesource.com/sdk/+/4d308f39115a2969fb9908055b37a93969d4fc8d
moves `runtime/third_parry` in dart to `third_party`, so license script
ignore-list have to be updated to accommodate new location.

Once the roll lands, old locations should be cleaned up from the
ignore-list.
  • Loading branch information
aam authored Nov 8, 2023
1 parent a1bad07 commit a70369d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ci/licenses_golden/tool_signature
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Signature: 69d986a7b2275b798b574b6aea2c1b78
Signature: 4b8678841cc9a099770862d08fb15c47

8 changes: 6 additions & 2 deletions tools/licenses/lib/paths.dart
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,15 @@ final Set<String> skippedPaths = <String>{
r'third_party/dart/pkg', // packages that don't become part of the binary (e.g. the analyzer)
r'third_party/dart/runtime/bin/ffi_test',
r'third_party/dart/runtime/docs',
r'third_party/dart/runtime/third_party/binary_size', // not linked in either
r'third_party/dart/runtime/third_party/d3', // Siva says "that is the charting library used by the binary size tool"
// TODO(aam): remove as a dup
r'third_party/dart/runtime/third_party/binary_size',
// TODO(aam): remove as a dup
r'third_party/dart/runtime/third_party/d3',
r'third_party/dart/runtime/vm/service',
r'third_party/dart/sdk/lib/html/doc',
r'third_party/dart/third_party/binary_size', // not linked in
r'third_party/dart/third_party/binaryen', // not linked in
r'third_party/dart/third_party/d3', // Siva says "that is the charting library used by the binary size tool"
r'third_party/dart/third_party/d8', // testing tool for dart2js
r'third_party/dart/third_party/devtools', // not linked in
r'third_party/dart/third_party/firefox_jsshell', // testing tool for dart2js
Expand Down

0 comments on commit a70369d

Please sign in to comment.