Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Check subclass gtk check #745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Apr 22, 2022

So in case we want to enforce this checks at all levels, this check enforces it.

@GuillaumeGomez GuillaumeGomez force-pushed the check-subclass-gtk-check branch 2 times, most recently from ba93ca8 to 364830f Compare April 22, 2022 15:41
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me if we just want to add it everywhere instead of deciding case by case. @bilelmoussaoui ?

@GuillaumeGomez
Copy link
Member Author

Still remains the question if we should put this check before running it in the parent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants