Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor spdx bug fixes for heuristics #146

Merged
merged 1 commit into from
Oct 12, 2022
Merged

minor spdx bug fixes for heuristics #146

merged 1 commit into from
Oct 12, 2022

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Oct 12, 2022

Signed-off-by: Brandon Lum [email protected]

pxp928
pxp928 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we should move the strings.ToLower to the assembler level. Can be another PR.

mlieberman85
mlieberman85 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit d416b62 into main Oct 12, 2022
@kodiakhq kodiakhq bot deleted the spdx-quick-fixes branch October 12, 2022 16:08
mrizzi added a commit to mrizzi/guac that referenced this pull request Oct 9, 2024
@mrizzi
TC-1814 SPDX SBOM describing multiple packages/artifacts (guacsec#146)
44ca3c7 
Signed-off-by: mrizzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@mlieberman85 mlieberman85 mlieberman85 approved these changes

@SantiagoTorres SantiagoTorres Awaiting requested review from SantiagoTorres

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac

@rgreinho rgreinho Awaiting requested review from rgreinho

@trmiller trmiller Awaiting requested review from trmiller

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumjjb @mlieberman85 @pxp928