Fixes: "uninitialized constant MiniTest::Unit::Guard::MinitestNotifier (NameError)" in 1.9.x

[grimen]

Since updating minitest and guard-minitest Guard raised error on every run.

[ream88]

+1

[snuggs]

PLEASE can someone update this? I'm having this error currently as we speak.

[somebox]

+1

[ivanjovanovic]

+2

[aspiers]

Me too

[dcunited001]

I am as well. running 1.9.2-head, should I be running 1.9.3?

i looked into the code and 'guard/minitest' loads 'guard', which loads 'guard/notify'. i think the problem is when it loads the minitest/notifier file, its under the Minitest namespace, so it loads the class "MiniTest::Unit::Guard::MinitestNotifier", instead of Guard::MinitestNotifier. When i set a binding.pry on one of my tests, the Guard::MinitestNotifier class exists

I think this might have something to do with the way i'm requiring files/modules in my spec_helper. This is what i'm using to start up guard:
RUBYOPT=-rminitest/pride bundle exec guard start

[dcunited001]

nevermind, just saw your commit hah

[metaskills]

I am using guard-minitest with a 2.3.14 app on 1.8.7 and hit this error too. Would love to see a gem release so I do not have to monkey patch.

[aspiers]

I created my own fork from the patched fork, merged some other fixes in, and then changed my Gemfile:

gem 'guard-minitest', :git => 'git://github.com/aspiers/guard-minitest.git'

This is cleaner and more manageable than manually editing code, but I agree the patch should be pulled. Having said that, I gave up on guard-minitest altogether because there were too many other issues. I get the impression it's not really being maintained any more.

[snuggs]

Well there's definitely not an issue of contributors wanting to maintain. I being one of them myself.

[aspiers]

Luckily github makes that possible even without the approval of the original maintainer. Just make sure that your fork contains merges of all the good patches from everyone else's (if you look in the git network you will see TONS of unmerged forks) and then update the issues where appropriate to say that your fork has a fix. Then people will start using and writing patches against yours instead of the "official" one :) After all, the maintainer's job is pretty much just merging, and in a decentralized system anyone can do that :)

[metaskills]

@aspiers Have you tried contacting the maintainer of this repo and ask if you can get access to both this repo as a collaborator? Github makes that really easy. Also, rubygems.org makes it easy to add another owner to the gem space, see here. http://guides.rubygems.org/command-reference/#gem_owner

When I took over active development for the less-rails gem, the old author was more than willing to let me start working in both of the official spaces. I can even help on this project too since I have been pushing MiniTest for some time now. Lemme know.

BTW, I forked your repo on my work account and published a 'guard-minitest-decisiv' gem as a quick patch to a bundler issues. Seems 1.1rc is broken and will always pull in a :git based even if that gem is in a group that is supposed to be ignored using the --without option.

[snuggs]

Already contacted multiple of the repo owners. No dice.

[heathd]

+1

I just did exactly the same fix and then saw others have been here before me!

[yannlugrin]

I planned time early next week for the maintenance of this gem

[zhon]

+1

[bltavares]

+1

[yannlugrin]

release 0.5.0.rc1 include this pull request

[snuggs]

The heavens have spoken! TY @yannlugrin

[metaskills]

"officially" awesome