ci: Explicitly grant permissions to updating workflow #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a recent GitHub organisational change, we're now required to explicitly list the permissions needed within a workflow. This workflow runs on the 10th day of every month, bumping the version of AWS CDK libraries being used. It'll create a PR editing the `package.json` and `package-lock.json` files, therefore, grant these permissions.
NovemberTang
approved these changes
Jul 13, 2023
|
🎉 This PR is included in version 50.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The workflow to automatically update AWS CDK libraries is failing, with a lack of permissions:
Following a recent GitHub organisational change, we're now required to explicitly list the permissions needed within a workflow.
This workflow runs on the 10th day of every month, bumping the version of AWS CDK libraries being used. It'll create a PR editing the
package.jsonandpackage-lock.jsonfiles, therefore, grant these permissions.How to test
I've triggered the workflow. It has succeeded, and raised the PR #1934.
How can we measure success?
Our automations start working again.
Have we considered potential risks?
N/A
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩