Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): Require explicit UserData type instead of string in Pattern props. #2378

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

AshCorr
Copy link
Member

@AshCorr AshCorr commented Jul 22, 2024

What does this change?

Updates our EC2 Pattern to require an explicit UserData prop instead of a string. This is part of our work to enable Cloudformation Replace deployments in our ASG.

This is a BREAKING change as applications relying on the type being a string will need to make a code change in order to update their GuCDK version.

Details on this change can be found in the included changeset file: .changeset/thick-owls-remain.md

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: cf58c7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/cdk Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AshCorr AshCorr marked this pull request as ready for review July 22, 2024 11:32
@AshCorr AshCorr requested a review from a team as a code owner July 22, 2024 11:32
@AshCorr AshCorr merged commit 234bca7 into main Jul 22, 2024
4 checks passed
@AshCorr AshCorr deleted the ash/explicit-user-data branch July 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants