Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a speed on pngquant to make it faster #3335

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Set a speed on pngquant to make it faster #3335

merged 1 commit into from
Jun 1, 2021

Conversation

AWare
Copy link
Contributor

@AWare AWare commented Jun 1, 2021

What does this change?

Set a speed on pngquant to make it faster

How can success be measured?

pngquant is faster and less likely to fail

Screenshots

Who should look at this?

Tested?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment

@AWare AWare requested a review from a team as a code owner June 1, 2021 09:47
@paperboyo
Copy link
Contributor

Thanks for not making it 10 :-). This is good. One day, we should stop optimising non-transparent images to PNG, which is stupid (too big files, 256 colours). They should just be optimised to JPG.

@AWare
Copy link
Contributor Author

AWare commented Jun 1, 2021

@paperboyo it would have been more work to do so

twrichards
twrichards approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving given simplicity of code change, but haven't tested myself (but I assume you and or @paperboyo have)

@AWare AWare merged commit 9c35baf into main Jun 1, 2021
@AWare AWare deleted the aw-pngquant-speed branch June 1, 2021 10:47
@prout-bot
Copy link

Seen on image-loader, auth (merged by @AWare 9 minutes and 8 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on kahuna, metadata-editor (merged by @AWare 9 minutes and 13 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on collections, media-api (merged by @AWare 9 minutes and 19 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on usage (merged by @AWare 9 minutes and 24 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on cropper, image-loader-projection (merged by @AWare 9 minutes and 28 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on leases (merged by @AWare 9 minutes and 46 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twrichards twrichards twrichards approved these changes

Assignees
No one assigned
Labels
Seen-on-auth Seen-on-collections Seen-on-cropper Seen-on-image-loader Seen-on-image-loader-projection Seen-on-kahuna Seen-on-leases Seen-on-media-api Seen-on-metadata-editor Seen-on-usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AWare @paperboyo @prout-bot @twrichards