change ophan module name to stop define() curl.js error

[feedmypixel]

before

We have been seeing the following error when curl loads the Membership Ophan script.
Note the Membership Ophan script loads.

after

Changing the module name to 'ophan/membership'

curl.js expects a named module to use its true name. There are no single-word module names in a package. All module names in packages take the form "[package-name]/[module-path]". ref

The error goes away and the Membership Ophan script loads.

[rtyley]

👍 just talked through this with @feedmypixel . To resummarise:

• we've always had some define() errors in sentry against Ophan, since before I introduced PR Use a Membership-specific Ophan script that identifies us as our own platform #134
• @feedmypixel thinks those errors were probably device dependant
• With PR Use a Membership-specific Ophan script that identifies us as our own platform #134 we started getting those errors for EVERYBODY.
• the errors don't actually seem to stop us getting Ophan stats
• once this PR is in, we should have less noise and be able to diagnose device-specific problems

[prout-bot]

Overdue on PROD (merged by @feedmypixel 15 minutes and 2 seconds ago) What's gone wrong?

[prout-bot]

Seen on PROD (merged by @feedmypixel 17 minutes and 54 seconds ago) Please check your changes!

[philwills]

AMD named module loading is such a needless minefield. 😿

[rtyley]

This went out with TeamCity build 4479... let's see if the errors die down...

[rtyley]

So far, looking better...

https://app.getsentry.com/the-guardian/membership/?query=duplicated

[davidrapson]

@feedmypixel @rtyley Great work, glad to get rid of this noise.

@feedmypixel Is the named module issue that caused this just curl idiosyncrasy? Would be interesting to know if this would happen with the default requirejs module loader / almond.