Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Trigger snyk #223

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Aug 12, 2022

Snyk integration. This PR tests whether or not integration with a snyk GHA will work out of the box. If it passes and has the correct org name it can be merged.

@kenoir
Copy link
Contributor Author

kenoir commented Aug 15, 2022

The error indicates esbuild-android-64 was not found in package-lock.json. It is referenced as an optionalDependency though??

@jfsoul
Copy link

jfsoul commented Sep 12, 2022

Strongly suspect this is caused by npm/cli#4828

@jfsoul jfsoul force-pushed the nori/test-snyk-integration-120822 branch from c964d2b to a0d4f39 Compare September 26, 2022 15:58
@jfsoul
Copy link

jfsoul commented Sep 26, 2022

Regenerated lock file, but now failing tests... I think we'll have to leave this one to the team.

@jonathonherbert jonathonherbert force-pushed the nori/test-snyk-integration-120822 branch from a0d4f39 to b2ae0aa Compare February 2, 2023 09:29
@mchv
Copy link
Member

mchv commented Feb 28, 2023

@jonathonherbert Could you look to integrate this please?

@jonathonherbert jonathonherbert force-pushed the nori/test-snyk-integration-120822 branch from 2ee713c to b2ae0aa Compare March 31, 2023 11:04
@jonathonherbert
Copy link
Contributor

jonathonherbert commented Mar 31, 2023

@kenoir @jfsoul – looks like this is now working. No change on our side, so looks like Snyk has solved. Thanks for raising the PR! Should we close this, or merge?

(edit: CI is now failing for what appear to be unrelated reasons, there'll be another PR to fix)

@jonathonherbert jonathonherbert force-pushed the nori/test-snyk-integration-120822 branch from d2b8190 to aa5782c Compare March 31, 2023 11:20
@jonathonherbert jonathonherbert force-pushed the nori/test-snyk-integration-120822 branch from acc8817 to 949db96 Compare April 24, 2023 07:24
@jonathonherbert jonathonherbert merged commit ff46e5f into main Apr 24, 2023
@jonathonherbert jonathonherbert deleted the nori/test-snyk-integration-120822 branch April 24, 2023 07:27
@github-actions
Copy link

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants