New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove sidebar once Composer uses its own. #254

Open

rhystmills wants to merge 1 commit into main from rm/remove-sidebar

Contributor

rhystmills commented Aug 22, 2023

This PR removes sidebar code that has been moved to Composer.

Test locally with Composer using yalc, as specified in the readme. Does Typerighter function as expected in Composer?


          First pass at removing redundant sidebar code from library

990585b

rhystmills changed the title ~~Remove sidebar once Composer uses its own.~~ feat!: Remove sidebar once Composer uses its own.

Contributor

simonbyford commented Sep 20, 2023

Looks good!

I think you'll need to remove Sidebar.spec.tsx. If this spec has any value, I wonder if we should port it to flexible-content?

We'll also need to remove the call to createSidebarView from pages/index.ts (which seems to power https://guardian.github.io/prosemirror-typerighter/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet