-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for #365 reduce camera resolution and remove one unneeded bitmap #366
Conversation
With the default motion detection sensitivity threshold performance is better on this branch. However reducing the threshold to something around 948 I am still running into ANRs. :/ |
... but no OOMs?
…On Thu, Feb 7, 2019, at 3:57 PM, Arka Prava Basu wrote:
With the default motion detection sensitivity threshold performance is
better on this branch. However reducing the threshold to something
around 948 I am still running into ANRs. :/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#366 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB4gwv7TwdXrZK3q9qnIWW9MFzjzlWcks5vLIx8gaJpZM4apJ2B>.
|
Faced OOMs too! Will provide the crashlog in some time. |
- we are creating too many in memory bitmaps just for fancy UI that isn't that usable - this now displays a simple "motion detected" string instead of the change detection overlay
This latest commit should vastly simplify the processing going on during motion detection. The problem was really in the whole overlay bitmap UI generation. That UI is fun, but not that usable. I am now just displaying a simple string "motion detection" to indicate a match. This is part of new work on showing more of an interactive display for all sensor matches, like "Sound Detected" or "Device Moved" etc, so that you can see in one view all of the various sensor states. |
Can confirm! No more ANRs or OOM errors 👍 ! However the number of Triggers of type Motion(Camera) is significantly reduced. Is this intended? |
Preliminary testing. Would be great if someone can cross-verify. |
- this is a replacement for the removal of the bitmap overall, which was causing OOMs and ANRs - this is much more functional, useful, though not quite as sexy :(
Notes: Getting a crash using camera on nexus 4 & 5 (AOS 5&6), with the monitor continuing in the background. Less frames could benefit the load on notifications. Without the overlay it's very hard to use sensitivity config. Edit: after latest commit, feedback for when sound and motion is detected works well and is intuitive. Makes much more sense moving forward. Thank you both.
|
@lukeswitz I found and fixed that crash. Otherwise, going to finish this up, and then work on improving tuning and feedback UI in another PR. |
No description provided.