Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get haven building again! Update libraries, gradle, etc. #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fat-tire
Copy link
Collaborator

Not really tested, but it builds in AS 2022.1.1 c8 targeting sdk 33

Mostly updates to libraries and gradle and some new requirements in the manifest. To address a warning in updated fresco 2.6.0 had to add new dependency:

"com.facebook.infer.annotation:infer-annotation:0.18.0"

Again, I didn't test this really. That's important to emphasize. But it built fine and I was able to run it on a device (api 32) and the emulator (api 16) and flip back and forth between screens and stuff.

Inspired by issue #456

Not really tested, but it builds in AS 2022.1.1 c8 targeting sdk33

To address a warning in updated fresco 2.6.0 had to add new dependency:

"com.facebook.infer.annotation:infer-annotation:0.18.0"
@lukeswitz
Copy link
Collaborator

Still crashes, bugs & can’t send messages. Point of this release?

@fat-tire
Copy link
Collaborator Author

fat-tire commented Jul 20, 2022

This... "release"?

The point of this "release" is that with these changes, the build now completes on recent Android Studio targeting sdk 33. Did not crash for me when I tried it out, but as I probably should have emphasized, "Not really tested... I didn't test this really. That's important to emphasize." I probably also should have noted it also will not pick up your dirty laundry by the hamper and that it may contain references to facebook libraries.

Anyhoo, thanks for the detailed bug report. Looking forward to your contributed fixes!

@fat-tire
Copy link
Collaborator Author

I have not been following the issues at all. I only saw that the build hadn't been updated in forever and when I loaded it up, it did't build. Any effort to get the app back and address hundreds or millions of issues will have to start with a working build. That's all i did as a prerequisite for anyone who might want to take one of the issues that I haven't even looked at on. You're welcome.

@n8fr8
Copy link
Member

n8fr8 commented Jul 20, 2022

@lukeswitz I'm sorry you are feeling so frustrated about the state of this project. I appreciate the work put in the past, and will do what I can moving forward to respect that contribution.

Otherwise, thanks @fat-tire for the build update. A first step in a long road to this being truly active again of course, but appreciated to deal with the cracks in the foundation.

@kmstr113
Copy link

kmstr113 commented Jul 29, 2022

So what is the state of the onion link inbound and outbound? I have looked through some of the issues, and none seem to be related to this particular branch, though after reading the comments I see that that may not be the case. I understand Signal is also broken. I am of the opinion that Signal is not a terrific solution for comms to the end user. I feel that the onion link to the device is likely better. Is there anyone specifically working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants