Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #75: Prevent loss of data on Device Rotation in Accel and Micro… #76

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Fixes #75: Prevent loss of data on Device Rotation in Accel and Micro… #76

merged 1 commit into from
Dec 24, 2017

Conversation

opticod
Copy link
Contributor

@opticod opticod commented Dec 23, 2017

…phone Configure Activity by fixing the layout to portrait.

Signed-off-by: Anupam Das [email protected]

@opticod
Fixes guardianproject#75: Prevent loss of data on Device Rotation in …
7d1d5d5 
…Accel and Microphone Configure Activity by fixing the layout to portrait.

Signed-off-by: Anupam Das <[email protected]>
@n8fr8
Copy link
Member

n8fr8 commented Dec 24, 2017

Looks good... perhaps the whole app should just be locked to portrait?

@n8fr8 n8fr8 merged commit 3fcfc61 into guardianproject:master Dec 24, 2017
@opticod
Copy link
Contributor Author

opticod commented Dec 24, 2017

Not necessarily, fixing this in new issue.

@opticod opticod mentioned this pull request Dec 24, 2017
Closed
percy-g2
percy-g2 reviewed Dec 29, 2017
View reviewed changes
Copy link
Contributor

@percy-g2 percy-g2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding android:configChanges="orientation|screenSize|keyboardHidden" will handle the changes.

@opticod
Copy link
Contributor Author

opticod commented Dec 29, 2017

@percy-g2
Orientation of AccelConfigureActivity & MicrophoneConfigureActivity - had been kept portrait, because it will be convenient for users to slide the wheel to change detection threshold and to see the graph at the same time as discussed in Issue #100 and fixed in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@percy-g2 percy-g2 percy-g2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opticod @n8fr8 @percy-g2