Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Undo and Redo commands with WordWrap enabled #1867

Closed
luizfernandonb opened this issue Jul 20, 2022 · 4 comments
Closed

Use Undo and Redo commands with WordWrap enabled #1867

luizfernandonb opened this issue Jul 20, 2022 · 4 comments

Comments

@luizfernandonb
Copy link

luizfernandonb commented Jul 20, 2022

Is your feature request related to a problem? Please describe.
No, it's just a feature, which in this case would be to be able to use Undo and Redo commands with WordWrap activated in a TextView.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jul 21, 2022
@tig tig closed this as completed in ec08224 Jul 22, 2022
@luizfernandonb
Copy link
Author

@BDisp, @tig i believe this PR of yours has broken some parts of the TextView, a text file loaded using LoadFile() doesn't even load

image

Also when you add enough characters for a line break to occur, an extra space is embedded at the end of the first line:
image

And when we try to erase some characters, an exception is thrown (The text is not even erased):
image

@BDisp
Copy link
Collaborator

BDisp commented Jul 23, 2022

I think is better to reopen this issue or create a new one. I confirm this bugs and I'll try to fix them.

@luizfernandonb
Copy link
Author

@tig, can you reopen this issue please?

@tig tig reopened this Jul 23, 2022
@BDisp
Copy link
Collaborator

BDisp commented Jul 23, 2022

Also when you add enough characters for a line break to occur, an extra space is embedded at the end of the first line

The extra space at the end of a line is for allows the cursor stay visible, otherwise the user can have some difficult to discover on what position he is in the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants