Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Docs "View Source" link broken #2025

Closed
tig opened this issue Sep 16, 2022 · 0 comments · Fixed by #2027 or #2038
Closed

API Docs "View Source" link broken #2025

tig opened this issue Sep 16, 2022 · 0 comments · Fixed by #2027 or #2038
Labels
build-and-deploy Issues regarding to building and deploying Terminal.Gui docs Can be resolved via a documentation update

Comments

@tig
Copy link
Collaborator

tig commented Sep 16, 2022

I added support for View Source via docfx in #1914, but it didn't get enabled in main until I merged #1955 into main just now.

However, because Docfx always uses `'git config --get remote.origin.url' to determine the URL (see dotnet/docfx#1544), the link is broken.

I believe the right way to fix this is to address #1745.

@tig tig added build-and-deploy Issues regarding to building and deploying Terminal.Gui docs Can be resolved via a documentation update labels Sep 16, 2022
@tig tig closed this as completed in #2027 Sep 16, 2022
tig added a commit that referenced this issue Sep 16, 2022
…rce Works (#2027)

* Fixes #1991 - Broken link in README

* Force push to main to update api docs after fixing #1874

* Fixes #1745 - Github action to generate API docs

* Try 2 - Fixes #1745 - Github action to generate API docs

* Try 3 - Fixes #1745 - Github action to generate API docs

* Try 4 - Fixes #1745 - Github action to generate API docs

* Try 4 - Fixes #1745 - Github action to generate API docs

* Try 6 - Fixes #1745 - Github action to generate API docs

* Removed docs folder because gh-pages branch is now used

* Ignore ./docs folder

* Fix readme for docfx

* Revert "merge"

This reverts commit 870a241, reversing
changes made to 48089bb.
tig added a commit that referenced this issue Sep 17, 2022
Re-Fixes #2025 - API Docs are now generated via Github Action - View Source Works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-deploy Issues regarding to building and deploying Terminal.Gui docs Can be resolved via a documentation update
Projects
None yet
1 participant