-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes APIs to support upcoming Web console feature #1770
Conversation
…le/gui.cs into web-console-feature
@@ -385,7 +411,7 @@ protected virtual void Dispose (bool disposing) | |||
|
|||
static void ProcessKeyEvent (KeyEvent ke) | |||
{ | |||
if(RootKeyEvent?.Invoke(ke) ?? false) { | |||
if (RootKeyEvent?.Invoke (ke) ?? false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the space after invoke may be accidental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's how .editorconfig is configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting stuff guys!
See my comments.
Terminal.Gui/Core/Application.cs
Outdated
@@ -210,6 +215,24 @@ static void OnQuitKeyChanged (Key oldKey) | |||
/// </summary> | |||
public static bool IsMouseDisabled { get; set; } | |||
|
|||
/// <summary> | |||
/// By default this is false which will continue executing the <see cref="RunLoop(RunState, bool)"/> method, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poor English phrasing. I think you mean:
"Set to true to cause the RunLoop method to exit after the first iterations. Set to false (the default) to cause the RunLoop to continue running until Application.RequestStop()
is called."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done thanks.
They are independent workflows. Theoretically they run in parallel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
Our team, and especially @BDisp have been working quite hard and have produced a web console driver for Gui.cs. Our driver needs visibility into some internal variables and we've also found/fixed a couple typos and bugs.
For #1642