Exposes APIs to support upcoming Web console feature #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le/gui.cs into web-console-feature
JessicaMulein
commented
Jun 4, 2022
| @@ -385,7 +411,7 @@ protected virtual void Dispose (bool disposing) | |||
|
|
|||
| static void ProcessKeyEvent (KeyEvent ke) | |||
| { | |||
| if(RootKeyEvent?.Invoke(ke) ?? false) { | |||
| if (RootKeyEvent?.Invoke (ke) ?? false) { | |||
There was a problem hiding this comment.
the space after invoke may be accidental?
There was a problem hiding this comment.
No it's how .editorconfig is configured.
tig
requested changes
Jun 7, 2022
Terminal.Gui/Core/Application.cs
Outdated
| @@ -210,6 +215,24 @@ static void OnQuitKeyChanged (Key oldKey) | |||
| /// </summary> | |||
| public static bool IsMouseDisabled { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// By default this is false which will continue executing the <see cref="RunLoop(RunState, bool)"/> method, | |||
There was a problem hiding this comment.
Poor English phrasing. I think you mean:
"Set to true to cause the RunLoop method to exit after the first iterations. Set to false (the default) to cause the RunLoop to continue running until Application.RequestStop() is called."
tig
changed the title
|
Now is the
It's not supposed the
|
They are independent workflows. Theoretically they run in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team, and especially @BDisp have been working quite hard and have produced a web console driver for Gui.cs. Our driver needs visibility into some internal variables and we've also found/fixed a couple typos and bugs.
For #1642