Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1959. GoToEnd should not fail on an empty TreeView #1960

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Fixes #1959. GoToEnd should not fail on an empty TreeView #1960

merged 2 commits into from
Aug 25, 2022

Conversation

jmelosegui
Copy link
Contributor

Fixes #1959 - GoToEnd should not fail on an empty TreeView

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

tig
tig reviewed Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tig
tig approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thank you!

@tig tig merged commit 73846b3 into gui-cs:develop Aug 25, 2022
@jmelosegui jmelosegui deleted the fix_treeview_go_to_end branch August 25, 2022 21:35
@jmelosegui
Copy link
Contributor Author

@tig thanks for merging this PR.
Question.
What is the frequency in which the master branch is updated and a new nuget version is published to nuget.org?

@tig
Copy link
Collaborator

tig commented Aug 25, 2022

When someone asks me to do it ;-)

@renovate renovate bot mentioned this pull request Sep 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

@BDisp BDisp BDisp approved these changes

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GoToEnd should not fail on an empty TreeView
3 participants
@jmelosegui @tig @BDisp