Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added abstract MakeColor and CreateColors to create the colors at once. #1972

Merged
merged 5 commits into from
Sep 5, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Aug 28, 2022

Per #666 - It has long wanted to do this to change the colors in one place for all drivers. I didn't named this PR in the form of "Fixes" because could have another refactors to remove duplicate code, but this one was very significant.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp
Copy link
Collaborator Author

BDisp commented Aug 29, 2022

Toplevel Color Scheme:
imagem

Base Color Scheme:
imagem

Dialog Color Scheme:
imagem

Menu Color Scheme:
imagem

Error Color Scheme:
imagem

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete the old, commented out code?

@BDisp BDisp requested a review from tig August 30, 2022 13:44
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 30, 2022

Can you delete the old, commented out code?

Done. Thanks.

@tig tig merged commit 389d0be into gui-cs:develop Sep 5, 2022
@BDisp BDisp deleted the consoledriver-create-colors-unified branch September 5, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants