-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for JSON minimum
, maximum
, exclusiveMinimum
, and exclusiveMaximum
#1023
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Michał Moskal <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 70.26% 63.02% -7.25%
==========================================
Files 62 63 +1
Lines 4470 4668 +198
==========================================
- Hits 3141 2942 -199
- Misses 1329 1726 +397 ☔ View full report in Codecov by Sentry. |
minimum
, maximum
, exclusiveMinimum
, and exclusiveMaximum
minimum
, maximum
, exclusiveMinimum
, and exclusiveMaximum
Note: we have one xfail here due to the fact that JSON apparently allows trailing Ready for review. |
Another note: JSON Schema Draft4 has a slightly different convention around Currently, our Draft202012 validator will reject these schemas, so we should be safe not to handle that case internally. Allowing Draft4 might open a bit of a can of worms, so I want to punt on that for at least a while. |
JSON support for integer and float bounds.
Closes #1019 (thanks for the code @mmoskal!)