Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: separate error while running gulpfile into task not found and fail to run #262

Merged

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Mar 21, 2024

This PR separates the error while running gulpfile into task not found and fail to run, and adds a test case for the ‘task not found’ error.
However, the test case for fail to run error is not added because I could not find the case to occur fail to run error.

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sttk! I've updated the PR to normalize the error properties like in Undertaker. This looks good to go 👍

@phated phated merged commit 9a1d013 into gulpjs:master Mar 22, 2024
18 checks passed
@sttk sttk deleted the separate-errors-into-taskNotFound-and-failToRun branch March 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants