-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add extends
syntax
#103
Conversation
@phated This pr is generally good! I'm sorry that I'm slow on the uptake. Wrong idea (and my poor english) had hindered my understanding. As you commented, BTW, there are one thing I'd like you to confirm. Will the way to specify |
@sttk don't worry about it! Your work heavily influenced this code.
I think it's important to switch the |
ecfc62e
to
99e7de3
Compare
7990353
to
4ce1a2f
Compare
This comment has been minimized.
This comment has been minimized.
@sttk this has taken me a long time to come back to, but I am hoping you can review this PR because it adds the |
Oh, and this is a breaking change because we changed the syntax to an array of fined objects (instead of a single object). |
@phated OK, I'll review this PR this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phated I've reviewd this PR, and I didn't find any problem. Great!
@sttk this is my (very hacky) initial work on my vision for
extends
syntax. Please review and make any suggestions. I still need to find answers on all the TODOs and write a ton of tests (which will likely result in refactoring).Closes #101 (supersedes it)