(Don't Merge) Test refactor #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
LGTM |
|
LGTM |
| file.base = basePath; | ||
| // Ensure the base always ends with a separator | ||
| // TODO: add a test for this | ||
| file.base = path.normalize(basePath + path.sep); |
There was a problem hiding this comment.
since path.normalize() will fix 'foo//' to foo/ (or backslashes if windows), to be safe I would consider doing basePath + '/' + path.sep (edited: nvm I misread path.sep to be some other path variable. I'm pretty sure that will always normalize out to have a path at the end)
There was a problem hiding this comment.
I actually think this needs to be pushed down into vinyl but I will do that separately from this PR
|
this looks great |
|
@phated I sent a PR to this branch with an utterly pedantic change. So yeah, this looks awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for review. Once I have some feedback, I'll push it to master to keep the 2 commits separate.
cc'ing anyone that might be remotely familiar since there's a lot of changes.
@contra @terinjokes @erikkemperman @jonschlinkert