Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using static_cast instead of old style cast #108

Merged
merged 1 commit into from
Mar 19, 2021
Merged

using static_cast instead of old style cast #108

merged 1 commit into from
Mar 19, 2021

Conversation

philbucher
Copy link
Contributor

This is a warning in GCC when using -Wold-style-cast

This is a warning in GCC when using -Wold-style-cast
@philbucher
Copy link
Contributor Author

I am not sure if there is a reason for using the old style cast, please check

BTW you could consider making this file a system_header like e.g. catch2 does, this way no warnings show up from it

#ifdef __clang__
#    pragma clang system_header
#elif defined __GNUC__
#    pragma GCC system_header
#endif

But then you would no longer see them during development I think
Just a suggestion

@gulrak
Copy link
Owner

gulrak commented Mar 19, 2021

Hi, thank you for the PR, indeed I didn't want to hide warnings, as I prefer to change to code to avoid them. Those old-style casts are a result of copying code from an old tooling file of mine and I should have replaced them, so thanks for fixing it.

@gulrak gulrak merged commit b8cff0c into gulrak:master Mar 19, 2021
@philbucher philbucher deleted the patch-1 branch March 22, 2021 11:37
@philbucher
Copy link
Contributor Author

cool thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants