Proposal: Performance optimization for Windows #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::shared_ptr
tostd::unique_ptr
becausestd::unique_ptr
does not use reference counter.std::shared_ptr<void>
(for storing handle) to custom unique_handle class becausestd::shared_ptr
use reference counter.In all cases, a reference count is not needed, since the stored object exists in a single instance.
Replace
std::shared_ptr<void>
tostd::unique_ptr
is wrong, becausestd::unique_ptr
doesn't call deleter on zero pointer and zero - is valid handle value.