Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing string_view path method #25

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix missing string_view path method #25

merged 1 commit into from
Aug 15, 2019

Conversation

karjonas
Copy link
Contributor

This is needed to be able to compile using a c++17 standard library for both gcc and clang.

@gulrak gulrak merged commit 4b10425 into gulrak:master Aug 15, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 15, 2019

Indeed, that helps. I think I'll add C++17 tests to the CI scripts in the next days, to ensure stable support against C++17.

Thanks for supplying the fix!

@karjonas karjonas deleted the string_view branch August 15, 2019 13:23
@karjonas
Copy link
Contributor Author

Thanks, nice library!

@gulrak gulrak added this to the v1.2.6 milestone Aug 27, 2019
@gulrak
Copy link
Owner

gulrak commented Feb 5, 2020

Hi @karjonas! There is interest to move to the more liberal MIT license. To allow this to happen, I would like to ask you as a contributor, to agree to this re-licensing with a reply to issue #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants