Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexically_relative: ignore trailing slash on base #57

Merged
merged 1 commit into from
Mar 23, 2020
Merged

lexically_relative: ignore trailing slash on base #57

merged 1 commit into from
Mar 23, 2020

Conversation

ligfx
Copy link
Contributor

@ligfx ligfx commented Mar 22, 2020

Previously,

fs::path("a/b").lexically_relative("a/")

would incorrectly return "../b". Now it returns "b".

Fixes #56

@ligfx
lexically_relative: ignore trailing slash on base
e3201da 
Previously,

    fs::path("a/b").lexically_relative("a/")

would incorrectly return "../b". Now it returns "b".
@gulrak
Copy link
Owner

gulrak commented Mar 23, 2020

Thank you for the Issue and PR with Test. Indeed I prefer that behavior too.

@gulrak gulrak merged commit 82d5d83 into gulrak:master Mar 23, 2020
@gulrak gulrak added this to the v1.3.1 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.

lexically_relative should ignore trailing slash on base
2 participants
@ligfx @gulrak