fix: crash when trying to wiggle duration Infinity

gunnartorfis · Sep 11, 2024 · 3e81b34 · 3e81b34
1 parent 76f98f3
commit 3e81b34
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/example/src/ToastDemo.tsx b/example/src/ToastDemo.tsx
@@ -69,6 +69,9 @@ export const ToastDemo: React.FC = () => {
       <Button
         title="Wiggle toast"
         onPress={() => {
+          if (toastId) {
+            toast.wiggle(toastId);
+          }
           toast.wiggle('123');
         }}
       />
@@ -312,6 +315,7 @@ export const ToastDemo: React.FC = () => {
           const id = toast.success('Infinity toast', {
             duration: Infinity,
             dismissible: false,
+            id: 'infinity',
             action: {
               label: 'Acknowledge',
               onClick: () => {

diff --git a/src/toast.tsx b/src/toast.tsx
@@ -121,6 +121,11 @@ export const Toast = React.forwardRef<ToastRef, ToastProps>(
     }, [wiggleSharedValue]);
 
     const wiggleHandler = React.useCallback(() => {
+      // we can't send Infinity over to the native layer.
+      if (duration === Infinity) {
+        return;
+      }
+
       // reset the duration
       timerStart.current = Date.now();
       startTimer();
@@ -131,7 +136,7 @@ export const Toast = React.forwardRef<ToastRef, ToastProps>(
       } else {
         wiggle();
       }
-    }, [wiggle, wiggleSharedValue, startTimer]);
+    }, [wiggle, wiggleSharedValue, startTimer, duration]);
 
     React.useImperativeHandle(ref, () => ({
       wiggle: wiggleHandler,