Move relational fields out of abstract base models #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChatterBot's abstract base models for Django are suppose to make it easier for a developer to create a new model, based on the existing ones with their own modifications. Unfortunately, having related fields like foregin keys will result in errors when trying to create new models because the fields of the abstract parent class are still evaluated by Django and because they can only reference the origional models.
This reverts commit a2c71e4.
vkosuri
previously approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatterBot's abstract base models for Django are suppose to make it easier for a developer to create a new model, based on the existing ones with their own modifications.
Unfortunately, having related fields like foreign keys will result in errors when trying to create new models because the fields of the abstract parent class are still evaluated by Django and because they can only reference the original models.
This pull request represents one possible solution, before merging these changes I plan to investigate the possibility of referencing the settings file in the model to achieve an effect similar to how Django implements their default User model which can be accessed via
settings.AUTH_USER_MODEL.